코루틴 적용기 입니다#10
Open
wkdehdlr wants to merge 11 commits into
Open
Conversation
2. response 패키지 위치 이동 3. Ticker 클래스구현 4. TickerProvider 구현
2. viewmodel repository map으로 수정 3. DI 수정 4. 어댑터 클릭리스너 추가 5. Exchange 모델 추가
2. ExchangeActivity 추가
async, await 적용 2. computeResult Dispatchers.IO 추가 3. 코루틴 exception Handler 추가
sport0102
requested changes
Feb 12, 2020
sport0102
left a comment
sport0102
left a comment
There was a problem hiding this comment.
- RxJava 쪽은 안봤습니다!
- 클린아키텍쳐도 적용해주셨으면 좋겠습니다!
- Ticker리스트로 foreach를 3번 도는데 이걸 좀 더 효율적으로 바꿨으면 좋겠다는 소망이 있습니다...
| list.add(ETicker(0,t1[0].exchangeName, t1[0].last, t1[0].volume)) | ||
| list.add(ETicker(0,t2.exchangeName, t2.last, t2.volume)) | ||
| list.add(ETicker(0,t3.exchangeName, t3.last, t3.volume)) | ||
| val sortedWith = list.sortedWith(Comparator<ETicker> { a: ETicker, b: ETicker -> |
There was a problem hiding this comment.
list.sortBy{it.nowPrice} or list.sortByDecending{it.nowPrice} 로 축약해서 쓸수있을 것 같습니다
| viewModel.getBithumbTickerList() | ||
| // viewModel.getTickerList("KRW") | ||
| // initRecyclerView() | ||
| // viewModel.getBithumbTickerList() |
There was a problem hiding this comment.
이런 뷰모델의 init 작업은 viewModel의 init{} 에서 진행하셔도 좋을 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.