Merged
Conversation
Collaborator
Author
|
This was tested. Only booleans are supported for now. Should be pretty simple to review. |
Alex33856
requested changes
Jan 24, 2026
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
viciscat
reviewed
Jan 29, 2026
Collaborator
viciscat
left a comment
viciscat
left a comment
There was a problem hiding this comment.
Small nitpick i guess, not gonna request changes since it's minor and it isn't that important from avoiding duplicate code a bit
Alex33856
added
merge conflicts
# Conflicts: # src/main/java/de/hysky/skyblocker/DisableAll.java # src/main/java/de/hysky/skyblocker/config/ConfigNullFieldsFix.java # src/main/java/de/hysky/skyblocker/config/SkyblockerConfigManager.java # src/main/java/de/hysky/skyblocker/skyblock/item/HotbarSlotLock.java # src/main/java/de/hysky/skyblocker/skyblock/item/ItemProtection.java # src/main/resources/assets/skyblocker/lang/en_us.json
LifeIsAParadox
added
reviews needed
Collaborator
Author
|
Should be good now. |
Alex33856
approved these changes
Apr 21, 2026
LifeIsAParadox
added
merge me please
AzureAaron
approved these changes
Apr 21, 2026
Alex33856
pushed a commit
that referenced
this pull request
Apr 21, 2026
* Add boolean config commands * Clean up null fields fix * Intellij is being weird with indents * Clean up more config stuff * Add feedback and refactor * Add config query * Fix spotless * Update commands * Solve merge conflicts * Fix config patches * Rename command again * Separate command registration * Change formatting of feedback messages --------- Co-authored-by: alex <8379108+Alex33856@users.noreply.github.com> (cherry picked from commit 545a9c3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to modify the config with commands.