Use BlockPosSet over Set<BlockPos>#2172
Draft
InspectorBoat wants to merge 10 commits intoSkyblockerMod:mainfrom
Draft
Use BlockPosSet over Set<BlockPos>#2172InspectorBoat wants to merge 10 commits intoSkyblockerMod:mainfrom
InspectorBoat wants to merge 10 commits intoSkyblockerMod:mainfrom
Conversation
Contributor
InspectorBoat
commented
Feb 23, 2026
InspectorBoat
commented
- Rather more performant than HashSet
- Somewhat more performant than LongOpenHashSet
- Removes the problem of having to perform defensive clones because of MutableBlockPos
Collaborator
kevinthegreat1
left a comment
kevinthegreat1
left a comment
There was a problem hiding this comment.
Is this pr meant to be ready? It hasn't been updated in a while.
| do { | ||
| // TODO: Switch to this when Vector API stabilizes | ||
| /* | ||
| LongVector n = LongVector.fromArray(LongVector.SPECIES_512, this.entries, i); |
Collaborator
There was a problem hiding this comment.
Should this be species preferred?
LifeIsAParadox
added
the
merge conflicts
Contributor
Author
|
Sorry, I've been busy with life stuff lol. The hashset itself should be ready, but I want to add benchmark tests & do fuzzing first in a separate repository. |
Collaborator
|
This is a skyblock mod you don't need fuzz testing lol. Just let me know if you need any help. |
LifeIsAParadox
removed
the
merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.