Skip to content

Comments

Matter Thermostat: Add OnOff cluster support#2760

Open
nickolas-deboom wants to merge 1 commit intomainfrom
add/on-off-cluster-support-for-matter-thermostat
Open

Matter Thermostat: Add OnOff cluster support#2760
nickolas-deboom wants to merge 1 commit intomainfrom
add/on-off-cluster-support-for-matter-thermostat

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Feb 5, 2026

Add OnOff cluster support for Air Purifier and Fan device types. This cluster is optionally supported for these device types starting with Matter 1.4.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Results

   72 files    487 suites   0s ⏱️
2 530 tests 2 530 ✅ 0 💤 0 ❌
4 348 runs  4 348 ✅ 0 💤 0 ❌

Results for commit fbefadb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/embedded_cluster_utils.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/utils.lua 85%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/legacy_device_configuration.lua 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/capability_handlers.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua 82%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against fbefadb

Add OnOff cluster support for Air Purifier and Fan device types. This
cluster is optionally supported for these device types starting with Matter 1.4.

CHAD-17538
@nickolas-deboom nickolas-deboom force-pushed the add/on-off-cluster-support-for-matter-thermostat branch from 0f62386 to fbefadb Compare February 12, 2026 21:23
@hcarter-775
Copy link
Contributor

was thinking, we may want to update this recently added logic for this PR since it's now possible for the devices to get switch after the thermostatMode are initially set up, right? Maybe the gating should be changed to be based on the OnOff cluster support on the right endpoint?

At the same time, the air purifier case (the only one that might be affected) wouldn't have thermostat stuff added until the same time that switch gets added, so it might not really be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants