Matter Switch: Subscribe to power topology attributes rather than read them#2792
Open
hcarter-775 wants to merge 2 commits intomainfrom
Open
Matter Switch: Subscribe to power topology attributes rather than read them#2792hcarter-775 wants to merge 2 commits intomainfrom
hcarter-775 wants to merge 2 commits intomainfrom
Conversation
hcarter-775
requested review from
ctowns,
gharveymn,
greens and
nickolas-deboom
hcarter-775
force-pushed
the
subscribe/power-topology-attributes
branch
from
6b97db6 to
191d97d
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3798f8b |
|
Invitation URL: |
Test Results 72 files 486 suites 0s ⏱️ Results for commit 3798f8b. ♻️ This comment has been updated with latest results. |
hcarter-775
force-pushed
the
subscribe/power-topology-attributes
branch
from
585b85e to
3798f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
To take advantage of the built-in retry mechanisms of the Matter subscription, move the AvailableEndpoints/PartsList attribute reads for multi-energy meter devices to the subscription list under certain conditions. The current logic should otherwise be unchanged.
Summary of Completed Tests
Tested on-device through a driver restart and a driverSwitched event, and with a fresh onboarding.
WWST test suite ran through with this driver link.