Make panel backend work with multi-thread/multi-process#240
Open
alejoe91 wants to merge 15 commits intoSpikeInterface:mainfrom
Open
Make panel backend work with multi-thread/multi-process#240alejoe91 wants to merge 15 commits intoSpikeInterface:mainfrom
alejoe91 wants to merge 15 commits intoSpikeInterface:mainfrom
Conversation
…nto web-curation-communication
…einterface-gui into web-curation-communication
|
|
||
| self.glyphs_data_source.patch(patch_dict) | ||
|
|
||
| patch_dict = {} |
Member
There was a problem hiding this comment.
I'm getting an error on refresh:
File "/home/nolanlab/fromgit/spikeinterface-gui/spikeinterface_gui/probeview.py", line 501, in _panel_refresh
glyph_patch_dict = self._panel_compute_unit_glyph_patches()
File "/home/nolanlab/fromgit/spikeinterface-gui/spikeinterface_gui/probeview.py", line 562, in _panel_compute_unit_glyph_patches
current_alphas = self.glyphs_data_source.data['alpha']
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'alpha'
I guess it has something to do with this code change??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panel can serv apps with parallelization, but in that case changes to bokeh models (e.g., refresh, change ranges, data sources) need to be "scheduled" using
pn.state.execute({function}, schedule=True), otherwise different threads/processes could conflict.This PR does exactly that by:
Also includes a few minor improvements to panel views