Skip to content

Use peak_sign in quality metrics.prepare_data to find template extremum #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ecobost wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Use peak_sign in quality metrics.prepare_data to find template extremum #4403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/spikeinterface/metrics/quality/quality_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def _set_params(
use_valid_periods=False,
periods=None,
# common extension kwargs
peak_sign=None,
peak_sign="neg",
seed=None,
skip_pc_metrics=False,
):
Expand Down Expand Up @@ -137,7 +137,7 @@ def _prepare_data(self, sorting_analyzer, unit_ids=None):
all_labels = sorting_analyzer.sorting.unit_ids[spike_unit_indices]

# Get extremum channels for neighbor selection in sparse mode
extremum_channels = get_template_extremum_channel(sorting_analyzer)
extremum_channels = get_template_extremum_channel(sorting_analyzer, peak_sign=self.params["peak_sign"])

# Pre-compute spike counts and firing rates if advanced NN metrics are requested
advanced_nn_metrics = ["nn_advanced"] # Our grouped advanced NN metric
Expand Down