Filled missing descriptions, updated some existing ones, minor tweaks.#302
Open
Laveig wants to merge 4 commits intoStrataSource:masterfrom
Open
Filled missing descriptions, updated some existing ones, minor tweaks.#302Laveig wants to merge 4 commits intoStrataSource:masterfrom
Laveig wants to merge 4 commits intoStrataSource:masterfrom
Conversation
As the summary implies. Some existing descriptions have been updated as well. The main reason behind this is the wiki - it uses the missing description values (i.e. spawnflags) and therefore looks bad. But more importantly, this adds more convinience in using entities, especially with the new descriptions.
Added more descriptions, moved `projected_tractor_beam_entity` into the fgd, added transparent nodraw.
Added Non-FGD visgroup.
Member
|
Wow these are a lot of changes, very impressive. Though it makes it hard to review - might be better as more focussed PRs for different groups of ents. Also have you compared to upsteam HA's FGDs? A lot of ents have descriptions there, which weren't copied into Strata's fork. Ideally we'll be merging them, so it's problematic if both differ... |
Author
|
I checked, strata fork seems to be up-to-date. What should I do now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
projected_tractor_beam_entityinto FGD (to matchprojected_wall_entity)func_fish_poolBaseClusteredLightEven though the
spawnflagsdescription is not visible in Hammer, Strata wiki still uses it, so it's there to make the page look better.