feat: support concat(toArray(...)) scalar includes#1384
Open
KyleAMathews wants to merge 2 commits intomainfrom
Open
feat: support concat(toArray(...)) scalar includes#1384KyleAMathews wants to merge 2 commits intomainfrom
KyleAMathews wants to merge 2 commits intomainfrom
Conversation
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-browser-wa-sqlite-persisted-collection
@tanstack/db-electron-sqlite-persisted-collection
@tanstack/db-ivm
@tanstack/db-node-sqlite-persisted-collection
@tanstack/db-react-native-sqlite-persisted-collection
@tanstack/db-sqlite-persisted-collection-core
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +355 B (+0.32%) Total Size: 111 kB
ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 4.23 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toArray(subquery.select(({ c }) => c.text))produces scalar arraysconcat(toArray(...))by lowering it through includes materialization instead of introducing a new aggregateselect()type-check without user-facing casts while preserving existing object-select inferenceDesign
collectiontocollection | array | concat__includes_scalar__field so the existing includes pipeline can keep using object-shaped child rowsselect()results without breaking spread/object projectionsBenchmarks
Actual live-query benchmark for:
content: concat(toArray(q.from({ c: chunkCollection }).where(...).orderBy(...).select(({ c }) => c.text)))Update performance is competitive, and the single-message incremental case is slightly better on the concat/toArray path. Preload is still a bit slower than the purpose-built aggregate.
Verification
Notes
groupBywith a new aggregate..select(...).fn.select(...)idea is still blocked becausefn.selectruns before includes materialize.