Skip to content

ci: Disable vcpkg build#2544

Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/ci-vcpkg
Apr 7, 2026
Merged

ci: Disable vcpkg build#2544
xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/ci-vcpkg

Conversation

@xezon
Copy link
Copy Markdown

@xezon xezon commented Apr 6, 2026

Until their compile times are fixed

Until their compile times are fixed
@xezon xezon added Critical Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Apr 6, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 6, 2026

Greptile Summary

This PR temporarily disables the win32-vcpkg, win32-vcpkg-profile, and win32-vcpkg-debug build matrix entries in the build-generals and build-generalsmd-win32 CI jobs while vcpkg compile times are addressed. The change is minimal, symmetric across both jobs, and easily reversible by uncommenting the entries.

Confidence Score: 5/5

Safe to merge — clean, intentional, and reversible CI configuration change with no logic or security issues

No P0/P1 findings. The change symmetrically comments out vcpkg matrix entries across two CI jobs with a clear stated reason, and is trivially reversible.

No files require special attention

Important Files Changed

Filename Overview
.github/workflows/ci.yml Temporarily comments out three win32-vcpkg matrix build variants in two CI jobs; change is symmetric and reversible

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GenCI Workflow] --> B[build-generals]
    A --> C[build-generalsmd-vc6]
    A --> D[build-generalsmd-win32]
    B --> B1[vc6 / vc6-profile / vc6-debug]
    B --> B2[win32 / win32-profile / win32-debug]
    B --> B3[win32-vcpkg variants DISABLED]
    style B3 fill:#ffcccc,stroke:#cc0000
    C --> C1[vc6 / vc6-profile / vc6-debug / vc6-releaselog]
    D --> D1[win32 / win32-profile / win32-debug]
    D --> D2[win32-vcpkg variants DISABLED]
    style D2 fill:#ffcccc,stroke:#cc0000
    B2 --> E[build-toolchain.yml]
    D1 --> E
Loading

Reviews (1): Last reviewed commit: "ci: Disable vcpkg build" | Re-trigger Greptile

@xezon xezon merged commit 164db08 into TheSuperHackers:main Apr 7, 2026
17 checks passed
@xezon xezon deleted the xezon/ci-vcpkg branch April 7, 2026 07:43
stephanmeesters pushed a commit to stephanmeesters/GeneralsGameCode that referenced this pull request Apr 7, 2026
Until their compile times are fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Anything related to building, compiling Critical Severity: Minor < Major < Critical < Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants