Fix a bug in getExtInfoList#26
Merged
Tobias-Kohn merged 2 commits intoTobias-Kohn:masterfrom May 1, 2026
Merged
Conversation
…ould all have a name of "<any>" in the returned structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a bug where when we called getExtInfoList, the name of some class functions would be "". On closer inspection this was the case when the .pyi had two definitions listed for a function with a @overload tag. I think TigerPython generalised it from a function type to an any type, and then it would use as the name of the item rather than the function name like it did for function types. This is really a three-line change, and I also adjusted the tests to test for this. I took the liberty of rolling a new release after the change.