PST Encoding and filename fixes 116#150
Merged
Conversation
…ng into a helper. Minor attachement fixes as well
adding table to html when pdf derivative is parsed
…t corrupt same data files
…ng with line endings in sample data
…d so we can use base libpff
…toml to repo for black config
Conflicts: .github/workflows/build.yml data/mbox-sample1/1/Headers.pickle data/mbox-sample1/1/Message.pickle data/mbox-sample1/2/Headers.pickle data/pst-outlook2019_MSO_16.0.10377.20023_64-bit/1/HTML_Encoding.txt mailbag/controller.py mailbag/derivatives/eml.py mailbag/derivatives/html.py mailbag/derivatives/mbox.py mailbag/derivatives/pdf.py mailbag/derivatives/txt.py mailbag/derivatives/warc.py mailbag/formats/eml.py mailbag/formats/pst.py mailbag/helper.py requirements.txt
This was referenced Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Contribution
What does this implement/fix? Explain your changes.
Previously we could only read attachment filenames with the get_filenames() method which has yet to be merged with libpff. Now this reads filenames from hex entries which works with libpff. This incorporates #145 which will be closed.
Also finally sorts out how to get correct encoding for PST files and no longer relies on character detect.
Also parses the mime from libpff instead of guessing it from the filename.
Link to issue?
#116
Pull Request Checklist
Please check if your PR fulfills the following requirements:
How has this been tested?
Operating System: win10
Python Version: 3.9.4
Licensing