Open
Conversation
Shamzik
added
runtime
apolyakov
requested changes
Apr 3, 2026
| #include <type_traits> | ||
| #include <utility> | ||
|
|
||
| #include <sys/stat.h> |
Contributor
There was a problem hiding this comment.
System headers should be placed in a single block
apolyakov
reviewed
Apr 7, 2026
|
|
||
| static auto create(size_t length, int32_t prot, int32_t flags, k2::descriptor fd, uint64_t offset) noexcept -> std::expected<mmap, int32_t>; | ||
|
|
||
| auto get_contents() noexcept -> string; |
Contributor
There was a problem hiding this comment.
As mmap is not a resource we don't need to return any of kPHP types here. Thus, we can use it in more contexts, e.g. in ComponentState. What do you think about changing the signature to auto data() noexcept -> std::span<std::byte>?
apolyakov
reviewed
Apr 7, 2026
| return std::unexpected{k2::errno_enomem}; | ||
| } | ||
|
|
||
| return kphp::fs::mmap::create(size, PROT_READ, MAP_PRIVATE | MAP_POPULATE, m_descriptor, 0).transform(&kphp::fs::mmap::get_contents); |
Contributor
There was a problem hiding this comment.
nit: std::addressof instead of &
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
file::get_contentsmethod and enables gzip test. Implementation was got fromfilekphp function.