[k2] add temporary stats for confdata and instance cache calls#1601
Open
[k2] add temporary stats for confdata and instance cache calls#1601
Conversation
apolyakov
added
runtime
apolyakov
force-pushed
the
apolyakov/k2-add-confdata-instance-cache-stats
branch
from
6641f35 to
dad8e3f
Compare
DrDet
reviewed
Apr 7, 2026
Comment on lines
+249
to
+250
| kphp::log::info("instance stats (approximately): confdata -> {}ms, instance cache -> {}ms", confdata_instance_state.time_ns >> 20, | ||
| instance_cache_instance_state.time_ns >> 20); |
Contributor
There was a problem hiding this comment.
let's add ratio to total request time?
apolyakov
force-pushed
the
apolyakov/k2-add-confdata-instance-cache-stats
branch
from
dad8e3f to
737b8f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.