new project structure#89
Conversation
|
Thanks for the effort put into this PR! Unfortunately, we're going to close it without merging. The core issue is scope: this PR restructures the entire project in a single change — moving from pageindex/ to src/pageindex/, splitting utils.py, introducing Pydantic config, reorganizing cookbook/, A few specific blockers:
That said, some of the ideas here are good — the utils.py modularization and Pydantic-based config validation are directions we'd welcome. If you'd like to contribute, we'd suggest breaking this into Closing this PR. Thanks again! |
|
Thanks for the detailed feedback and for taking the time to review the PR. That makes sense — I understand the concern about scope. I combined too many structural and functional changes into a single PR, which made it hard to review safely and incrementally. You’re also right about the specific blockers:
I appreciate the note that parts of the work were still useful, especially the utils modularization and the Pydantic-based config direction. I’ll take this feedback into account and, if I reopen contributions here, I’ll split them into smaller focused PRs with isolated changes and clearer review boundaries. Thanks again for the review. |
No description provided.