fix: payment hardening -- pricing, panics, external signer#5
Merged
mickvandijke merged 2 commits intomainfrom Apr 3, 2026
Merged
fix: payment hardening -- pricing, panics, external signer#5mickvandijke merged 2 commits intomainfrom
mickvandijke merged 2 commits intomainfrom
Conversation
- Make pay_for_merkle_tree_calldata() public in the unified PaymentVault handler - Add pay_for_merkle_tree_calldata() to external_signer.rs with MerklePaymentCalldataReturn type for external wallet signing - Uses the unified PaymentVault API (post-V2 refactor)
grumbach
force-pushed
the
fix/payment-upload-hardening
branch
from
c9de1f6 to
eff43ab
Compare
mickvandijke
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pay_for_merkle_tree_calldata()public in the unified PaymentVault handlerpay_for_merkle_tree_calldata()toexternal_signer.rswithMerklePaymentCalldataReturntype for external wallet signing (MetaMask, WalletConnect, etc.)Independent
This PR is self-contained. No dependencies on other PRs.
Test plan