feat!: include close group in PaymentQuote signed bytes#8
Draft
mickvandijke wants to merge 1 commit intomainfrom
Draft
feat!: include close group in PaymentQuote signed bytes#8mickvandijke wants to merge 1 commit intomainfrom
mickvandijke wants to merge 1 commit intomainfrom
Conversation
Add a `close_group` field to `PaymentQuote` containing the quoting node's view of the close group for the content address. This is signed as part of the quote to prevent a malicious node from lying about its close group membership. BREAKING CHANGE: `PaymentQuote` has a new `close_group` field and `bytes_for_signing` now requires a `close_group` parameter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close_groupfield toPaymentQuotecontaining the quoting node's view of the close group for the content address (up toCLOSE_GROUP_SIZEpeer IDs as raw 32-byte BLAKE3 hashes, excluding the quoting node itself).bytes_for_signingso it is covered by the quote's signature, preventing a malicious node from lying about its close group membership.Breaking Changes
PaymentQuotestruct has a newclose_group: Vec<[u8; 32]>field.PaymentQuote::bytes_for_signingnow takes an additionalclose_group: &[[u8; 32]]parameter.Test plan
🤖 Generated with Claude Code