Skip to content

fix: use SERVER_URL constant in A2ACardResolver constructor in HelloWorldClient #664#666

Merged
kabir merged 1 commit intoa2aproject:mainfrom
CokeLee777:issue-664
Feb 17, 2026
Merged

fix: use SERVER_URL constant in A2ACardResolver constructor in HelloWorldClient #664#666
kabir merged 1 commit intoa2aproject:mainfrom
CokeLee777:issue-664

Conversation

@CokeLee777
Copy link
Contributor

Description

Replace the hardcoded string literal "http://localhost:9999" with the existing SERVER_URL constant in the A2ACardResolver constructor call inside HelloWorldClient.

Fixes #664 🦕

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @CokeLee777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances code maintainability and consistency within the HelloWorldClient by standardizing the use of a predefined constant for the server URL. By replacing a direct string literal with SERVER_URL, it ensures that all references to the server address are unified, simplifying future updates and reducing the risk of discrepancies.

Highlights

  • Code Maintainability: Replaced a hardcoded server URL string literal with the existing SERVER_URL constant in the A2ACardResolver constructor call.
Changelog
  • examples/helloworld/client/src/main/java/io/a2a/examples/helloworld/HelloWorldClient.java
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces a hardcoded server URL with the existing SERVER_URL constant in the HelloWorldClient. This is a good practice that improves code maintainability and consistency. The change is straightforward and has been implemented correctly. I approve this change.

@kabir kabir merged commit 6a22243 into a2aproject:main Feb 17, 2026
11 checks passed
@kabir
Copy link
Collaborator

kabir commented Feb 17, 2026

Thank you @CokeLee777 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: a2a-java-sdk-examples-client: SERVER_URL constant not used in A2ACardResolver constructor in HelloWorldClient

3 participants