fix: prevent dialog/fullsize-dialog plugins from closing immediately after page load#821
Open
usman-khalid wants to merge 1 commit intoadobe:mainfrom
Open
fix: prevent dialog/fullsize-dialog plugins from closing immediately after page load#821usman-khalid wants to merge 1 commit intoadobe:mainfrom
usman-khalid wants to merge 1 commit intoadobe:mainfrom
Conversation
Member
|
I've got a more substantial fix for this already in the works. I'll send a PR this morning for you to look at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening a dialog or fullsize-dialog plugin within the first ~2-3 seconds of page load causes it to appear briefly then close on its own.
handleLibSwitchused standalonerender()into the shadow root, which conflicted with LitElement's own rendering. Async re-renders (e.g. fromcheckPreviewStatus) overwrote the dialog, closing it. Fixed by rendering the dialog through LitElement's reactive cycle instead.How Has This Been Tested?
Tested on localhost, https://library--da-live--usman-khalid.aem.page/ and with browser override on da.live
Screenshots (if appropriate):
N/A
Types of changes
Checklist: