feat(executor): forward signals to sandboxed process group to prevent orphans#39
Merged
feat(executor): forward signals to sandboxed process group to prevent orphans#39
Conversation
… orphans Fixes issue #37: when sx receives SIGINT/SIGTERM/SIGHUP it now delivers the signal to the entire sandboxed process group via kill(-pgid, ...), followed by a 2s grace period and SIGKILL escalation. A RAII PgidKillGuard ensures the subtree is cleaned up even on unexpected exit paths. - Add signal-hook and libc dependencies - Spawn child in its own process group (process_group(0)) - Add spawn_with_signal_forwarding with SIGTERM→SIGKILL escalation - Add PgidKillGuard for panic-safe cleanup - Add unit test for process group isolation - Add integration tests (tests/signal_test.rs) covering SIGTERM propagation and document the known SIGKILL limitation
5 tasks
Pierozi
added a commit
that referenced
this pull request
Apr 27, 2026
) When the sandboxed child was placed in its own process group (#39), it was no longer the tty foreground group, causing SIGTTIN on any tty read and hanging interactive shells. Add TtyForegroundGuard: hands the tty foreground to the child pgrp via tcsetpgrp after spawn (SIGTTOU suppressed during handoff) and restores the original foreground on drop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
Summary
sxreceives SIGINT/SIGTERM/SIGHUP, descendant processes in the sandboxed subtree were left orphaned and reparented to launchd — accumulating silently over time (especially Node--useNodeIpcworkers).process_group(0)) and forwarding signals viakill(-pgid, ...)ensures the entire subtree is torn down with a SIGTERM → 2s grace → SIGKILL escalation.PgidKillGuardRAII type provides panic-safe cleanup so the subtree is never orphaned even on unexpected exit paths.Test plan
cargo testpasses — unit test verifiesprocess_group(0)produces an isolated pgidcargo test --test signal_testpasses — integration test asserts zero descendants remain 3s after SIGTERM tosx