Add spec helper to simplify specs, and Gemfile to load required dev gems#16
Closed
jemmyw wants to merge 2 commits into
Closed
Add spec helper to simplify specs, and Gemfile to load required dev gems#16jemmyw wants to merge 2 commits into
jemmyw wants to merge 2 commits into
Conversation
percyhanna
approved these changes
Oct 26, 2018
percyhanna
left a comment
percyhanna
left a comment
There was a problem hiding this comment.
Looks good to me, but maybe another set of eyes would be good. 👍
Could we add CircleCI integration as well?
Author
|
@percyhanna ok for me to just merge these spec only changes? We should add circle in another PR I think |
|
@jemmyw Go for it, that can be iterated on after. 👍 |
avit
reviewed
Nov 15, 2018
| @@ -1 +1,3 @@ | |||
| --color No newline at end of file | |||
| --colour | |||
| @@ -0,0 +1,60 @@ | |||
| PATH | |||
There was a problem hiding this comment.
I don't think lockfiles should be included in gems: could we ignore this? They should be testable with whatever is the latest.
|
|
||
| s.add_dependency "nokogiri" | ||
| s.add_development_dependency "rspec" | ||
| s.add_development_dependency "rubocop", "< 0.56" |
schneidmaster
added a commit
that referenced
this pull request
Feb 1, 2021
Contributor
|
Superseded by #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.