feat: add changelog indexing to preview pipeline#1042
Open
dslovinsky wants to merge 1 commit intomainfrom
Open
feat: add changelog indexing to preview pipeline#1042dslovinsky wants to merge 1 commit intomainfrom
dslovinsky wants to merge 1 commit intomainfrom
Conversation
Add preview-changelog.ts uploader (uploadChangelogFile and uploadChangedChangelogFiles), add runChangelogIndexAndUpload to preview-index.ts, and route changelog files to the correct uploader in preview.ts. Co-Authored-By: Claude <noreply@anthropic.com>
🌿 Documentation Preview
|
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcdda3c2bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preview-changelog.tsuploader withuploadChangelogFile()anduploadChangedChangelogFiles()following the same pattern aspreview-mdx.tsrunChangelogIndexAndUpload()topreview-index.ts, called at the end ofrunIndexAndUpload()so both docs and changelog are indexed togetherfern/changelog/*.md) to the changelog uploader inpreview.ts, with reindex on new/deleted filesCompanion PR in docs-site repo: OMGWINNING/docs-site (ds/changelog-preview)
Test plan
pnpm preview— changelog index uploaded under{branch}:index:changelog.json{branch}:changelog:{filename}.mdfile — fast path uploads to Redis without reindexpnpm testpasses