Skip to content

chore: use lockfiles for NPM dependencies #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhukaihan merged 3 commits into from
Mar 24, 2026
Merged

chore: use lockfiles for NPM dependencies #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d06070
chore: use lockfiles for NPM dependencies
daniel-graham-amplitude Mar 11, 2026
6a58ec9
ci: add setup-node@v4 with Node 22 before npm ci in release workflow …
Copilot Mar 20, 2026
5abb468
fix: declare base64 and logger as gem dependencies (#82)
zhukaihan Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ jobs:
with:
ruby-version: 2.7

- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
cache: 'npm'

- name: Semantic Release --dry-run
if: ${{ github.event.inputs.dryRun == 'true'}}
env:
Expand All @@ -44,15 +50,8 @@ jobs:
GIT_COMMITTER_EMAIL: amplitude-sdk-bot@users.noreply.github.com
GEM_HOST_API_KEY: ${{secrets.GEM_HOST_API_KEY}}
run: |
npx \
-p lodash \
-p semantic-release@17 \
-p @semantic-release/changelog@5 \
-p @semantic-release/git@9 \
-p @google/semantic-release-replace-plugin@1.0 \
-p @semantic-release/exec@5 \
-p semantic-release-rubygem \
semantic-release --dry-run
npm ci
npm exec semantic-release -- --dry-run

- name: Semantic Release
if: ${{ github.event.inputs.dryRun == 'false'}}
Expand All @@ -64,12 +63,5 @@ jobs:
GIT_COMMITTER_EMAIL: amplitude-sdk-bot@users.noreply.github.com
GEM_HOST_API_KEY: ${{secrets.GEM_HOST_API_KEY}}
run: |
npx \
-p lodash \
-p semantic-release@17 \
-p @semantic-release/changelog@5 \
-p @semantic-release/git@9 \
-p @google/semantic-release-replace-plugin@1.0 \
-p @semantic-release/exec@5 \
-p semantic-release-rubygem \
semantic-release
npm ci
npm exec semantic-release
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
.idea/
*.iml
.DS_Store
node_modules/

# Used by dotenv library to load environment variables.
.env
Expand Down
2 changes: 2 additions & 0 deletions amplitude-experiment.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']
spec.extra_rdoc_files = ['README.md']

spec.add_dependency 'base64'
spec.add_dependency 'concurrent-ruby', '~> 1.2'
spec.add_dependency 'logger'

spec.add_development_dependency 'psych', '~> 4.0'
spec.add_development_dependency 'rake', '~> 13.0'
Expand Down
Loading
Loading