ARIES-2197 Add TLS/MTLS support to TCP Provider#60
Open
amichair wants to merge 7 commits intoapache:masterfrom
Open
ARIES-2197 Add TLS/MTLS support to TCP Provider#60amichair wants to merge 7 commits intoapache:masterfrom
amichair wants to merge 7 commits intoapache:masterfrom
Conversation
alien11689
reviewed
Apr 7, 2026
added 3 commits
April 20, 2026 15:25
…Service so that resources can be properly released
added 4 commits
April 20, 2026 19:58
…ol (~100x throughput)
…l with slight refactoring
Contributor
|
There are still some not resolved comments, you can take a look - I can also take a look when the previous branches are merged. |
Contributor
Author
|
strange, I see my response on every single one... but I also see the whole conversation above twice - some kind of github bug I guess. Which ones do you not see the answer to? |
Contributor
|
Maybe you didn't publish your comments? |
amichair
commented
Apr 21, 2026
Contributor
Author
There was a problem hiding this comment.
I think github turned my comments on the review into a new review... now you can see it here separately, for some reason some issues include your original comments and some don't show yours only my response. I don't know if u see what I see here, but I hope it's clear enough what goes where.
alien11689
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented TLS+MTLS+tests.
This PR sits on top of the ARIES-2121 PR, so that PR needs to be merged first.