Tune Ratelimiter config

[tarun-google]

Tuning the RateLimiter config

1. Adding GRPC_MAX_CONNECTION_AGE to solve sticky sessions problem. every 5 minutes workers get re-balanced to the newer pods.
2. setting statsd resources. With out them k8s is assigning a higher default value, which is useless. I do not expect statsd using heavy resources. anyway it scale along with the pods. Both statsd sidecar and envoy containers sit in same pod
3. Increasing the re-try count incase of connection error rather than throwing exception fast. Anyway Runner re-try the bundle again.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability, resource efficiency, and resilience of the Envoy RateLimiter configuration. It introduces mechanisms to mitigate sticky session problems, optimizes resource allocation for monitoring components, and improves the rate limiter's ability to handle transient connection errors gracefully. These changes aim to provide a more robust and scalable rate limiting solution within the environment.

Highlights

• GRPC Connection Management: Added GRPC_MAX_CONNECTION_AGE and GRPC_MAX_CONNECTION_AGE_GRACE environment variables to the ratelimit deployment to address sticky session issues by rebalancing workers to newer pods every 5 minutes.
• Resource Allocation for StatsD: Set explicit, minimal resource requests and limits for the statsd-exporter sidecar container to prevent Kubernetes from assigning unnecessarily high default values, optimizing resource usage.
• Rate Limiter Retry Logic: Increased the RPC retry count and delay in the EnvoyRateLimiterFactory to allow the rate limiter to retry connection errors for up to one minute before failing, reducing the need for the runner to retry entire bundles.
• Scalability and Resource Tuning: Adjusted the maximum number of replicas for the rate limit deployment from 5 to 100, and refined default resource allocations for both Redis and the ratelimit service containers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• examples/terraform/envoy-ratelimiter/ratelimit.tf
  • Added GRPC connection age environment variables to the ratelimit deployment.
  • Configured specific resource requests and limits for the statsd-exporter container.
• examples/terraform/envoy-ratelimiter/variables.tf
  • Increased the default maximum replicas for the rate limit deployment.
  • Introduced new variables for GRPC connection age and grace periods.
  • Updated default CPU requests and limits for Redis resources.
  • Adjusted default CPU and memory requests for ratelimit resources.
• sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/ratelimiter/EnvoyRateLimiterFactory.java
  • Increased the RPC retry count and delay for the Envoy RateLimiter.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩