Merged
Conversation
…s the correct way per Pydantic v2.11+.
Contributor
|
this needs minimum pin in pyproject.toml to accompany this |
Contributor
Author
|
@skrawcz done. |
Contributor
|
@vbhavh I think we want it for all pydantic dependencies in pyproject.toml. |
Contributor
Author
|
hey @skrawcz, is it solved now ? I have done it for all pydantic deps. |
Contributor
|
Could we add a test that confirms this? |
Contributor
Author
i'll add one in test/integrations. |
Contributor
Author
|
@elijahbenizzy done. |
skrawcz
reviewed
Mar 16, 2026
andreahlert
reviewed
Mar 18, 2026
Collaborator
andreahlert
left a comment
andreahlert
left a comment
There was a problem hiding this comment.
Tested locally with pydantic 2.12.5. All 32 existing tests pass. The core fix (accessing model_fields from the class) works correctly. However, this PR has several structural issues that need addressing.
Contributor
Author
|
On my way to fix all structural issues. |
Contributor
Author
|
hello @andreahlert, i have made all your asked structural changes. Thanks. |
andreahlert
added
kind/bug
skrawcz
approved these changes
Apr 4, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix of issue: #652
Changes:
type(model).model_fields accesses the attribute on the class, which is the correct way per Pydantic v2.11+.