[CALCITE-7343] RelToSqlConverter generate wrong sql when scalar correlated sub-query in Project#4810
Open
Dwrite wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-7343] RelToSqlConverter generate wrong sql when scalar correlated sub-query in Project#4810Dwrite wants to merge 1 commit intoapache:mainfrom
Dwrite wants to merge 1 commit intoapache:mainfrom
Conversation
mihaibudiu
approved these changes
Feb 27, 2026
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Show resolved
Hide resolved
Member
|
Please keep the PR title, commit message, and Jira title consistent with each other. Do not use "Fix" in the title. |
xiedeyantu
reviewed
Feb 28, 2026
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
mihaibudiu
approved these changes
Mar 2, 2026
…lated sub-query in Project
|
Member
|
I have no further comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes scalar correlated subquery SQL generation by ensuring proper table alias handling for correlation variables, particularly in deeply nested scenarios.
Changes
Core Strategy: Context-Aware Aliasing
Key Benefits:
Test Coverage
Future Work
Follow-up PRs will extend this fix to:
The infrastructure (correlation scope stack, Result.resetAliasForCorrelation) is designed to be reusable for these future enhancements.