Fix nic adapater and root disk controller for UEFI VMs#13108
Fix nic adapater and root disk controller for UEFI VMs#13108harikrishna-patnala wants to merge 1 commit intoapache:4.20from
Conversation
|
@blueorangutan package |
|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13108 +/- ##
============================================
+ Coverage 16.25% 16.26% +0.01%
- Complexity 13420 13440 +20
============================================
Files 5662 5665 +3
Lines 500161 500559 +398
Branches 60730 60791 +61
============================================
+ Hits 81300 81440 +140
- Misses 409777 410011 +234
- Partials 9084 9108 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (params != null && params.get(VmDetailConstants.NIC_ADAPTER) != null && !params.get(VmDetailConstants.NIC_ADAPTER).isEmpty()) { | ||
| nicAdapter = params.get(VmDetailConstants.NIC_ADAPTER); | ||
| } else if (MapUtils.isNotEmpty(params) && params.containsKey(GuestDef.BootType.UEFI.toString())) { | ||
| nicAdapter = "e1000"; |
There was a problem hiding this comment.
any reason of this change ?
There was a problem hiding this comment.
to address the issue mentioned in #11212, along with volumes addition of networks is also failing.
There was a problem hiding this comment.
thanks @harikrishna-patnala
"e1000" has low performance, which user should avoid
There was a problem hiding this comment.
okay @weizhouapache do you think "rtl813" is fine ?
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17735 |
3 participants
Description
The PR fixes the issue #11212
Issue: UEFI-based VMs on KVM were unable to attach more than a few additional disks or NICs because the default disk bus selection caused higher PCI device usage, leading to PCI slot exhaustion.
Fix: Updated the guest disk bus selection logic to use SCSI for Linux-based UEFI guests instead of VIRTIO, which reduces PCI device usage and improves support for attaching additional volumes and network interfaces. Existing Windows and non-UEFI behavior remains unchanged.
Fixed NIC attachment issues for UEFI VMs by defaulting the NIC adapter to e1000 when UEFI is enabled and no NIC adapter is explicitly specified.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?