Fix deleting backups through the UI using forced#8708
Closed
FelipeM525 wants to merge 1 commit into
Closed
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
0ee66bb to
43cb342
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the PR #6580, a new parameter called
forcedwas added to the APIdeleteBackup; however, these changes were not implemented in the UI; therefore, this PR aims to do so by creating a switch to allow the user to send a request to this API with theforcedparameter set to true through the UI.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Before:

After:

How Has This Been Tested?
First, I implemented the modifications and set ACS up in a local environment. Subsequently, I used the browser's dev tool to check if the request being sent had the forced parameter set to true when the switch was toggled, which it did. At last, I created a couple of backups and removed them successfully with the new switch toggled on.