Skip to content

Fix deleting backups through the UI using forced#8708

Closed
FelipeM525 wants to merge 1 commit into
apache:mainfrom
scclouds:issue-448
Closed

Fix deleting backups through the UI using forced#8708
FelipeM525 wants to merge 1 commit into
apache:mainfrom
scclouds:issue-448

Conversation

@FelipeM525
Copy link
Copy Markdown
Contributor

@FelipeM525 FelipeM525 commented Feb 26, 2024

Description

In the PR #6580, a new parameter called forced was added to the API deleteBackup; however, these changes were not implemented in the UI; therefore, this PR aims to do so by creating a switch to allow the user to send a request to this API with the forced parameter set to true through the UI.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Before:
image

After:
image

How Has This Been Tested?

First, I implemented the modifications and set ACS up in a local environment. Subsequently, I used the browser's dev tool to check if the request being sent had the forced parameter set to true when the switch was toggled, which it did. At last, I created a couple of backups and removed them successfully with the new switch toggled on.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Feb 26, 2024

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@FelipeM525 FelipeM525 closed this Feb 26, 2024
@FelipeM525 FelipeM525 deleted the issue-448 branch February 26, 2024 13:04
@DaanHoogland DaanHoogland added this to the unplanned milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants