branch-4.0: [fix](local exchange) Do global shuffle for shuffled join/set operator #60758#60763
Merged
yiguolei merged 1 commit intobranch-4.0from Feb 14, 2026
Merged
Conversation
#60758) Make followed_by_shuffled_operator() virtual and override it in hash join and set operators to correctly report shuffle requirements. For multi-child operators (hash join, set operations), the method now returns true if the operator itself is shuffled (and not colocated), ensuring proper global shuffle behavior in local exchange. Changes: - Make followed_by_shuffled_operator() virtual in base OperatorX class - Override in HashJoinBuildSinkOperatorX and HashJoinProbeOperatorX to return is_shuffled_operator() && !is_colocated_operator() - Override in PartitionedHashJoinProbeOperatorX and PartitionedHashJoinSinkOperatorX to delegate to inner operator - Override in SetProbeSinkOperatorX and SetSinkOperatorX to return !_is_colocate This fixes incorrect data distribution when shuffled join/set operators are used in pipelines with local exchange.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
yiguolei
approved these changes
Feb 14, 2026
github-actions
bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
skip buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #60758