FINERACT-2116: Add validation integration tests for Credit Bureau Configuration APIs#5460
Conversation
|
@DeathGun44 Please rebase this PR with latest |
abfde50 to
e7d8544
Compare
|
@adamsaghy please re-run the tests ,they should all be green now |
| return new Gson().toJson(map); | ||
| } | ||
|
|
||
| // TODO: Rewrite to use fineract-client instead! |
There was a problem hiding this comment.
Please do not introduce new functionalities which are not using the fineract-client framework!
adamsaghy
left a comment
There was a problem hiding this comment.
Kindly see my concerns!
e7d8544 to
8ee10c4
Compare
…figuration APIs Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
8ee10c4 to
3f89d1a
Compare
|
@adamsaghy Addressed — to keep scope aligned, I've migrated only the newly added helper methods to use fineract-client. I'll open a separate issue to migrate the remaining deprecated methods in the helper file. |
|
@adamsaghy I believe these failures are just flaky tests could you please rerun them? |
|
No, neither of them are related to tests. Signed commit check fails because you dont have set up GPG signature (which we will enforce soon), for now it would not block the merge. I have restarted the checks. |
|
@adamsaghy Regarding the 2 failing checks after re-run:
|
Description
This PR adds validation integration tests for Credit Bureau Configuration APIs (FINERACT-2116).
Tests cover:
configkey,value,descriptionaliasloanProductId,isCreditcheckMandatory,skipCreditcheckInFailure,stalePeriodImplementation notes:
Calls.ok()) instead of deprecated REST Assured utilsChecklist