HBASE-29871 During WAL write times out add DataNode address in. the exception message#7719
HBASE-29871 During WAL write times out add DataNode address in. the exception message#7719srinireddy2020 wants to merge 3 commits intoapache:masterfrom
Conversation
| if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) { | ||
| promise | ||
| .tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response")); | ||
| promise.tryFailure(new IOException( |
There was a problem hiding this comment.
@srinireddy2020
In other two places we are logging "channel.remoteAddress" in message and here dnInfo.toString.
Can't we keep it consistent?
There was a problem hiding this comment.
In the method parameter already having the DN details so no need to call channel.remoteAddress.
|
Please fix the spotless issue? |
srinireddy2020
force-pushed
the
HBASE-29871
branch
from
f7102a3 to
435757a
Compare
Spot less fixed. please check |
| } | ||
| String logInfo = "ack with firstBadLink as " + resp.getFirstBadLink(); | ||
| String logInfo = | ||
| "ack with firstBadLink as " + resp.getFirstBadLink() + " from datanode " + dnInfo; |
There was a problem hiding this comment.
Overall looks good. Just some minor nits.
In a previous change, we print both the hostname and IP when printing datanode info, details see: #6148
It might be better to follow that same pattern here?
There was a problem hiding this comment.
Comment addressed, please check.
|
@srinireddy2020 Please do a rebase as our github actions so we can finish the checks? Sorry we have changed the actions a bit so the scripts are broken... |
5 participants
For better debug, add datanode address to the exception message during WAL write times out