HBASE-29691: Change TableName.META_TABLE_NAME from being a global static#7730
Open
Kota-SH wants to merge 1 commit intoapache:masterfrom
Open
HBASE-29691: Change TableName.META_TABLE_NAME from being a global static#7730Kota-SH wants to merge 1 commit intoapache:masterfrom
Kota-SH wants to merge 1 commit intoapache:masterfrom
Conversation
Change TableName.META_TABLE_NAME from a global static constant to a dynamically discovered value from ConnectionRegistry. Key changes: - Add ConnectionRegistry.getMetaTableName() method for dynamic discovery - Add MetaTableNameStore for persisting meta table name in master region - Update TableName to support dynamic meta table name - Update HMaster to integrate with MetaTableNameStore - Update all client and server code to use dynamic meta table name - Add protobuf changes for meta table name in Registry.proto Refactoring for the test classes to be handled separately.
anmolnar
approved these changes
Feb 10, 2026
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
lgtm. What are the build failures?
kgeisz
suggested changes
Feb 11, 2026
| // TODO: How come Meta regions still do not have encoded region names? Fix. | ||
| // hbase:meta,,1.1588230740 should be the hbase:meta first region name. | ||
| // TODO: For now, hardcode to default. Future: lazy initialization based on config or make it use | ||
| // conenction |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| // conenction | |
| // connection |
| @@ -787,8 +787,13 @@ public static CellComparator getCellComparator(TableName tableName) { | |||
| */ | |||
| public static CellComparator getCellComparator(byte[] tableName) { | |||
| // FYI, TableName.toBytes does not create an array; just returns existing array pointer. | |||
Contributor
There was a problem hiding this comment.
nit: Is this comment still applicable?
| if (!createMetaEntriesFailures.isEmpty()) { | ||
| LOG.warn( | ||
| "Failed to create entries in hbase:meta for {}/{} RegionInfo descriptors. First" | ||
| "Failed to create entries in {}} for {}/{} RegionInfo descriptors. First" |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| "Failed to create entries in {}} for {}/{} RegionInfo descriptors. First" | |
| "Failed to create entries in {} for {}/{} RegionInfo descriptors. First" |
| if (!cfs.contains(family)) { | ||
| throw new HBaseIOException( | ||
| "Delete of hbase:meta column family " + Bytes.toString(family)); | ||
| "Delete of " + env.getMetaTableName() + " column family " + Bytes.toString(family)); |
Contributor
There was a problem hiding this comment.
nit: IMO this could be a little more clear
Suggested change
| "Delete of " + env.getMetaTableName() + " column family " + Bytes.toString(family)); | |
| "Invalid deletion of " + env.getMetaTableName() + " column family: " + Bytes.toString(family)); |
| LOG.debug("Loaded meta table name from Master Local Region: {}", cachedMetaTableName); | ||
| return cachedMetaTableName; | ||
| } | ||
| LOG.info("No stored meta table name found in Master Local Region: {}", cachedMetaTableName); |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| LOG.info("No stored meta table name found in Master Local Region: {}", cachedMetaTableName); | |
| LOG.info("No stored meta table name found in Master Local Region: {}", cachedMetaTableName); |
| startEndKeys.get(idx + 1).getFirst()) == 0) | ||
| ) { | ||
| throw new IOException("The endkey of one region for table " + tableName | ||
| + " is not equal to the startkey of the next region in hbase:meta." |
Comment on lines
+2024
to
+2028
| LOG.warn( | ||
| "Unable to close region " + hi.getRegionNameAsString() | ||
| + " because {} had invalid or missing " + HConstants.CATALOG_FAMILY_STR + ":" | ||
| + Bytes.toString(HConstants.REGIONINFO_QUALIFIER) + " qualifier value.", | ||
| connection.getMetaTableName()); |
Contributor
There was a problem hiding this comment.
nit: I see a mixture of using string concatenation as well as {} in the LOG.warn() method. IMO is should consistently use the {} convention.
Comment on lines
+2205
to
+2206
| LOG.info("Patching {} with .regioninfo: " + hbi.getHdfsHRI(), | ||
| connection.getMetaTableName()); |
Contributor
There was a problem hiding this comment.
nit: Mixture of string concatenation and {} in log method
Comment on lines
+2234
to
+2235
| LOG.info("Patching {} with with .regioninfo: " + hbi.getHdfsHRI(), | ||
| connection.getMetaTableName()); |
Contributor
There was a problem hiding this comment.
nit: Mixture of string concatenation and {} in log method
| + hbi.getMetaEntry().regionServer + " but is multiply assigned to region servers " | ||
| + Joiner.on(", ").join(hbi.getDeployedOn())); | ||
| "Region " + descriptiveName + " is listed in " + connection.getMetaTableName() | ||
| + " on region server " + hbi.getMetaEntry().regionServer + " but is multiply assigned" |
Contributor
There was a problem hiding this comment.
nit: Do you have any idea what they mean by "multiply assigned"? Like "multi-assigned"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-29691: Change TableName.META_TABLE_NAME from being a global static
Change TableName.META_TABLE_NAME from a global static constant to a dynamically discovered value from ConnectionRegistry.
Please refer to earlier discussion on the PR #7558 for further details.
Key changes:
Refactoring for the test classes to be handled separately.