HBASE-29756: Programmatically register related co-processor during initialization#7743
Open
sharmaar12 wants to merge 2 commits intoapache:HBASE-29081from
Open
HBASE-29756: Programmatically register related co-processor during initialization#7743sharmaar12 wants to merge 2 commits intoapache:HBASE-29081from
sharmaar12 wants to merge 2 commits intoapache:HBASE-29081from
Conversation
sharmaar12
force-pushed
the
prog_reg_cop
branch
from
b61c399 to
2909891
Compare
anmolnar
requested changes
Feb 12, 2026
| LOG.info("Updated {} readOnlyEnabled={}", this.getClass().getName(), | ||
| readOnlyEnabledFromConfig); | ||
| if (this.masterServices != null) { | ||
| manageActiveClusterIdFile(readOnlyEnabledFromConfig); |
Contributor
There was a problem hiding this comment.
I think there's an issue with this approach.
- We talked about briefly that the local
globalReadOnlyEnabledis not needed anymore, because coprocs will be loaded only when R/O mode is enabled. So, I think you should remove the field in this patch. - As a consequence this method will always be called with
readOnlyEnabledFromConfig == trueand the active cluster id file will never be removed.
I suggest to make this method static and call it from HMaster at line 4440. You don't need to resolve the coproc, just call the static method directly with the new configuration and do the management of cluster id file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.