REST spec: Add Optional UUID for Namespaces to OpenAPI spec#15317
REST spec: Add Optional UUID for Namespaces to OpenAPI spec#15317talatuyarer wants to merge 3 commits intoapache:mainfrom
Conversation
|
|
||
| class CreateNamespaceResponse(BaseModel): | ||
| namespace: Namespace | ||
| namespace_uuid: str | None = Field( |
There was a problem hiding this comment.
I think it's better to put this under the Namespace itself as an optional field, similar to how it's done for TableMetadata/ViewMetadata. We will then most likely need a separate NamespaceParser that reads/writes that optional uuid. Right now we only have a NamespaceSerializer and NamespaceDeserializer which serDe the levels of the namespace directly
There was a problem hiding this comment.
Sounds good! I changed the spec accordingly. I added oneOf we can accept string array or NamespaceObject which has optional uuid field.
…how it's done for TableMetadata/ViewMetadata.
There was a problem hiding this comment.
I would leave the example in
| type: string | ||
| example: [ "accounting", "tax" ] | ||
| oneOf: | ||
| - type: array |
There was a problem hiding this comment.
maybe extract this out into a NamespaceArray schema type so that it can be reused here and further below
| items: | ||
| type: string | ||
| example: [ "accounting", "tax" ] | ||
| oneOf: |
There was a problem hiding this comment.
This looks like it would be an incompatible change. We might need to consider a new endpoint to represent a new structure (e.g. a v2 list)
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
3 participants
This PR adds an optional
namespace-uuidto REST API namespace responses. This UUID uniquely identifies a namespace, allowing name reuse, and supports catalog synchronization. We discussed at last Catalog Sync.