chore(config): remove the deprecated configuration rocksdb.max_background_{compactions,flushes} and set default to -1#3398
Merged
git-hulk merged 6 commits intoapache:unstablefrom Mar 24, 2026
Conversation
- unset them from kvrocks.conf and update comments
Contributor
Author
|
Also I cannot recall if setting READONLY on the option makes it read-only for everything or just CLI...that would inform whether we update max_background_compactions to readonly. I can verify later. |
git-hulk
reviewed
Mar 23, 2026
Removed deprecated configuration options for background compactions and flushes.
git-hulk
previously approved these changes
Mar 23, 2026
Contributor
Author
|
@git-hulk Sorry will need another review. |
git-hulk
reviewed
Mar 24, 2026
Co-authored-by: hulk <hulk.website@gmail.com>
git-hulk
approved these changes
Mar 24, 2026
rocksdb.max_background_{compactions,flushes} default to -1rocksdb.max_background_{compactions,flushes} and set default to -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR will:
rocksdb.max_background_compactionsandrocksdb.max_background_flushesfrom2to-1kvrocks.confand update comments to reflect RocksDB's decision logic for max background threadsNOTE: This doesn't make it so that
rocksdb.max_background_compactionsis unsettable, likerocksdb.max_background_flushescurrently is. This may be desirable for people who do currently use the old overrides, but afaik it would lock people in tomax_background_flushes = 2- but that's already the case as far as I can tell.I ran each of:
Tests all pass and formatting changes are unrelated.
This is effectively an addition to #1665
See #3395 for more background.