HG-3394: Cache FileStatus in Footer to reduce redundant NameNode RPC calls#3395
Open
wangyum wants to merge 1 commit intoapache:masterfrom
Open
HG-3394: Cache FileStatus in Footer to reduce redundant NameNode RPC calls#3395wangyum wants to merge 1 commit intoapache:masterfrom
wangyum wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @wgtmac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When reading Parquet files from HDFS,
getFileStatus()is called twice for each file:ParquetFileReader.readAllFootersInParallel()ParquetInputFormat.getSplits()This creates redundant NameNode RPC calls. For workloads processing thousands of files, this redundancy significantly increases NameNode load and job startup time.
This PR caches
FileStatusin theFooterobject to eliminate redundant RPC calls, reducing NameNode RPC calls during Parquet file processing.What changes are included in this PR?
Footer.java: AddedFileStatusfield with backward-compatible constructorsParquetFileReader.java: PassFileStatuswhen creatingFooterobjectsParquetInputFormat.java: Reuse cachedFileStatusinstead of callingfs.getFileStatus()againTestFooterFileStatusCaching.java: New test suite with 5 tests proving RPC reductionAre these changes tested?
Yes. Added comprehensive test suite
TestFooterFileStatusCachingwith 5 test cases:Are there any user-facing changes?
No.
Closes #3394