PHOENIX-7758 Read repair with DistinctPrefixFilter can give incorrect results#2365
Open
tkhurana wants to merge 3 commits intoapache:masterfrom
Open
PHOENIX-7758 Read repair with DistinctPrefixFilter can give incorrect results#2365tkhurana wants to merge 3 commits intoapache:masterfrom
tkhurana wants to merge 3 commits intoapache:masterfrom
Conversation
kadirozde
reviewed
Feb 20, 2026
| conn.commit(); | ||
|
|
||
| ArrayList<String> expectedValues = Lists.newArrayList("a1", "a2"); | ||
| String selectSql = "SELECT distinct(id1) from " + dataTableName + " WHERE val1 = 'val1a'"; |
Contributor
There was a problem hiding this comment.
I think we need to return id2 too by using SELECT distinct(id1), id2 to verify that the query actually uses the expected rows. For this, we can use List<List<String>> expectedValues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.