fix: pass name instead of id for name param in SmartApifyStorageClient#775
Merged
fix: pass name instead of id for name param in SmartApifyStorageClient#775
Conversation
…lient All three `create_*_client` methods in `SmartApifyStorageClient` were passing `name=id` instead of `name=name`, silently discarding the user-provided name and using the id value (often None) instead. This broke name-based storage opening entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
===========================================
- Coverage 81.91% 68.06% -13.86%
===========================================
Files 46 46
Lines 2693 2693
===========================================
- Hits 2206 1833 -373
- Misses 487 860 +373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janbuchar
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_*_clientmethods inSmartApifyStorageClient(create_dataset_client,create_kvs_client,create_rq_client) were passingname=idinstead ofname=namenameargument and used theidvalue (oftenNone) instead, breaking name-based storage opening entirelyname=id->name=namein all three methodsTest plan
SmartApifyStorageClientand confirm it resolves to the correct named storage instead of default🤖 Generated with Claude Code