fix: stop silently swallowing exceptions in request queue #777
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdusek
added
adhoc
janbuchar
reviewed
Feb 11, 2026
src/apify/storage_clients/_apify/_request_queue_shared_client.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
===========================================
- Coverage 81.91% 68.06% -13.86%
===========================================
Files 46 46
Lines 2693 2693
===========================================
- Hits 2206 1833 -373
- Misses 487 860 +373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d and reclaim_request Both the single and shared request queue clients caught all exceptions in `mark_request_as_handled` and `reclaim_request`, logged them at DEBUG level, and returned `None`. This made it impossible for callers to distinguish between "request was not in progress" (legitimate None per the base class contract) and "API call failed" (swallowed error). Silently swallowing errors also meant metadata counters could drift from platform state without any visible indication of the problem. Remove the catch-all `except Exception` blocks and let exceptions propagate naturally so callers can handle failures appropriately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
force-pushed
the
fix/rq-clients-stop-swallowing-exceptions
branch
from
1f34f16 to
b807c69
Compare
vdusek
changed the title
janbuchar
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mark_request_as_handledandreclaim_requestin both the single and shared request queue clients were logged atDEBUGlevel, making API failures (network timeouts, auth errors, rate limits) effectively invisiblelogger.debugtologger.exceptionin all 4 exception handlers so these errors are visible and include full tracebacksTest plan
_update_requestnow produce visible log output with tracebacks🤖 Generated with Claude Code