Skip to content

[managed-resources]: add error and partial error types#1126

Open
saehejkang wants to merge 2 commits intoapple:mainfrom
saehejkang:add-error-type-for-managed-resource
Open

[managed-resources]: add error and partial error types#1126
saehejkang wants to merge 2 commits intoapple:mainfrom
saehejkang:add-error-type-for-managed-resource

Conversation

@saehejkang
Copy link
Contributor

@saehejkang saehejkang commented Jan 31, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

  • Definition of the ManagedResourceError type for ManagedResources.
  • Definition of ManagedResourcePartialError type for compound operations.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@jglogan
Copy link
Contributor

jglogan commented Feb 1, 2026

@saehejkang If you created your branch from jglogan:system-labels you target your branch to merge to it as well?

Then all my changes won't show up in your pull request. I believe that when that PR gets merged, this one will change to merge to main.

image

@saehejkang
Copy link
Contributor Author

If you created your branch from jglogan:system-labels you target your branch to merge to it as well?

Do I have to open the PR in your forked repo for that to work? I was planning on waiting until the jglogan:system-labels feature branch is merged to main, until I rebase this one. Just marked it as a draft for now, until it is ready for review (when the diff is fixed).

@jglogan
Copy link
Contributor

jglogan commented Feb 1, 2026

Ah yeah, I hadn't considered forks. Your plan makes sense.

@saehejkang saehejkang force-pushed the add-error-type-for-managed-resource branch from 9edb41c to 04920a1 Compare February 4, 2026 03:43
static func nameValid(_ name: String) -> Bool

/// The specific error codes that the resource can produce.
associatedtype ErrorCode: ManagedResourceErrorCode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each resource type (volume, image, etc.) will define there own error codes

@saehejkang saehejkang marked this pull request as ready for review February 4, 2026 03:47
@saehejkang saehejkang force-pushed the add-error-type-for-managed-resource branch from e79a406 to 2beb69a Compare February 20, 2026 04:25
@saehejkang saehejkang force-pushed the add-error-type-for-managed-resource branch from 4b56880 to 316599e Compare February 20, 2026 04:26
@saehejkang saehejkang changed the title [managed-resources]: Add error type [managed-resources]: add error and partial error types Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants