[managed-resources]: add error and partial error types#1126
[managed-resources]: add error and partial error types#1126saehejkang wants to merge 2 commits intoapple:mainfrom
Conversation
|
@saehejkang If you created your branch from jglogan:system-labels you target your branch to merge to it as well? Then all my changes won't show up in your pull request. I believe that when that PR gets merged, this one will change to merge to main. |
Do I have to open the PR in your forked repo for that to work? I was planning on waiting until the |
|
Ah yeah, I hadn't considered forks. Your plan makes sense. |
9edb41c to
04920a1
Compare
| static func nameValid(_ name: String) -> Bool | ||
|
|
||
| /// The specific error codes that the resource can produce. | ||
| associatedtype ErrorCode: ManagedResourceErrorCode |
There was a problem hiding this comment.
Each resource type (volume, image, etc.) will define there own error codes
e79a406 to
2beb69a
Compare
4b56880 to
316599e
Compare
Type of Change
Motivation and Context
ManagedResourceErrortype forManagedResources.ManagedResourcePartialErrortype for compound operations.Testing