fix: only enable rosetta by default when installed#1188
Open
manojmahapatra wants to merge 1 commit intoapple:mainfrom
Open
fix: only enable rosetta by default when installed#1188manojmahapatra wants to merge 1 commit intoapple:mainfrom
manojmahapatra wants to merge 1 commit intoapple:mainfrom
Conversation
Contributor
|
Hi @manojmahapatra, please setup signed commits. See: https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests |
Contributor
Author
|
Yes, it was missing on my new MBP, I've set it up correctly now. |
manojmahapatra
force-pushed
the
bug/rosetta-enabled-by-default
branch
from
6b9373f to
d7b9711
Compare
Contributor
Author
|
@jglogan when you've time, can you please review this? |
Contributor
@manojmahapatra Sorry I have been swamped and will continue to be through next week. I did get a chance to look at a cluster of PRs tonight. This looks perfectly fine. We've still got a few lingering container lifecycle bugs that hit us nondeterministically in CI, so I'm trying to get a build working and then will approve/merge. Apologies for the delay! |
Contributor
Author
|
No worries, and no rush btw. I just wanted to bubble this up. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Addressing #1136
On fresh installs,
build.rosettadefaults totrue, which makes the builder VM request rosetta even when it isn’t installed. That looks like hits a potentialVirtualization.frameworkinstall‑prompt bug and fails the build unexpectedly. This change keeps the existing auto install behavior for explicit opt‑in while preventing the default path from enabling Rosetta unless it’s already installed.Testing