Put CLI and container-core-images in a keychain access group.#1257
Open
jglogan wants to merge 1 commit intoapple:mainfrom
Open
Put CLI and container-core-images in a keychain access group.#1257jglogan wants to merge 1 commit intoapple:mainfrom
jglogan wants to merge 1 commit intoapple:mainfrom
Conversation
- Closes apple#1253 (hopefully). - Requires apple/containerization#553. - We share a keychain between the CLI and the image helper, but the user needs to opt-in the image helper for access to entries created by the CLI. Since both apps are notarized with the same team ID, we should be able to use an access group to avoid this step for release builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
container image pushaftercontainer registry loginrequires keychain access #1253 (hopefully).Type of Change
Motivation and Context
It's easy to forget to hit "Allow All" in the opt-in dialog, and logins using short-lived access tokens constantly trigger the dialog in any case.
Testing