Skip to content

Prevent failing test after compaction#390

Merged
apetenchea merged 2 commits intomainfrom
prevent-failing-after-compaction
Mar 2, 2026
Merged

Prevent failing test after compaction#390
apetenchea merged 2 commits intomainfrom
prevent-failing-after-compaction

Conversation

@apetenchea
Copy link
Member

@apetenchea apetenchea commented Mar 2, 2026

This is a test-only PR for test_collection_management


Note

Low Risk
Test-only change that adds retry/sleep around collection creation; low production risk, but may mask real failures and increase CI runtime when the issue reproduces.

Overview
Hardens test_collection_management against intermittent CollectionCreateError when creating an autoincrement-key collection by adding a bounded retry loop (up to 10 attempts with a short sleep) before asserting key_options.

Also adds the required time import and a clearer failure message when all retries are exhausted.

Written by Cursor Bugbot for commit a051565. This will update automatically on new commits. Configure here.

@apetenchea apetenchea self-assigned this Mar 2, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Free Tier Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bugbot Autofix prepared fixes for both issues found in the latest run.

  • ✅ Fixed: Missing break causes unnecessary retries after success
    • Added a break immediately after successful key option assertions so the retry loop exits once collection creation succeeds.
  • ✅ Fixed: Missing space in concatenated assertion message string
    • Inserted explicit spaces in the adjacent string literals for both the retry print and final assertion message to produce readable text.

Create PR

Or push these changes by commenting:

@cursor push e120f3f323
Preview (e120f3f323)
diff --git a/tests/test_collection.py b/tests/test_collection.py
--- a/tests/test_collection.py
+++ b/tests/test_collection.py
@@ -209,7 +209,7 @@
             )
         except CollectionCreateError:
             print(
-                "Failed to create collection with autoincrement key generator,"
+                "Failed to create collection with autoincrement key generator, "
                 "retrying..."
             )
             time.sleep(3)
@@ -218,8 +218,9 @@
         assert key_options["key_generator"] == "autoincrement"
         assert key_options["key_increment"] == 9
         assert key_options["key_offset"] == 100
+        break
     assert col is not None, (
-        "Failed to create collection with autoincrement"
+        "Failed to create collection with autoincrement "
         "key generator after multiple attempts"
     )
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@apetenchea apetenchea merged commit 88b59eb into main Mar 2, 2026
11 checks passed
@apetenchea apetenchea deleted the prevent-failing-after-compaction branch March 2, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant