Open
Conversation
pguyot
reviewed
Feb 19, 2026
| uses: actions/upload-pages-artifact@v3 | ||
| with: | ||
| name: github-pages | ||
| path: ./docs |
Collaborator
There was a problem hiding this comment.
Is this intended? It's not in the commit message.
Collaborator
Author
There was a problem hiding this comment.
Yes, that was due to a recent change to rebar.config that removed the custom "docs" directory so that docs are built in the standard "doc" directory that hex uses as the default.
I suppose I should have made this fix in a separate commit referencing the commit where this should have also been changed. I just forgot because #53 was open for a while before it was approved. I will update the commit message to also mention this fix specifically.
Root privileges are needed to set the locale to UTF-8 for ex_doc, but sudo is not available in the erlang:28 container, so instead the setup-beam action is used after setting the locale. For an example of sudo failing, see this workflow run: https://github.com/atomvm/atomvm_packbeam/actions/runs/22147359424 Fixes incorrect doc dir that was not updated in commit a08370c (PR atomvm#53). Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
fix_publish_docs
branch
from
a08370c to
1e0e1cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root privileges are needed to set the locale to UTF-8 for ex_doc, but sudo is not available in the erlang:28 container, so instead the setup-beam action is used after setting the locale.
For an example of sudo failing, see this workflow run: https://github.com/atomvm/atomvm_packbeam/actions/runs/22147359424
Fixes incorrect doc dir that was not updated in commit a08370c (PR #53).