Skip to content

fix: wrap crypto TypeError in JsonWebTokenError for malformed EC/RSA signatures #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vansh1811 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

fix: wrap crypto TypeError in JsonWebTokenError for malformed EC/RSA signatures #1018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,14 @@ module.exports = function (jwtString, secretOrPublicKey, options, callback) {
try {
valid = jws.verify(jwtString, decodedToken.header.alg, secretOrPublicKey);
} catch (e) {
return done(e);
// Wrap low-level crypto errors (e.g. TypeError from malformed EC/RSA
// signatures) in a JsonWebTokenError so callers always receive a
// consistent, documented error type instead of an undocumented TypeError.
// See: https://github.com/auth0/node-jsonwebtoken/issues/767
if (e instanceof JsonWebTokenError) {
return done(e);
}
return done(new JsonWebTokenError('invalid signature'));
}

if (!valid) {
Expand Down Expand Up @@ -208,8 +215,8 @@ module.exports = function (jwtString, secretOrPublicKey, options, callback) {

if (options.issuer) {
const invalid_issuer =
(typeof options.issuer === 'string' && payload.iss !== options.issuer) ||
(Array.isArray(options.issuer) && options.issuer.indexOf(payload.iss) === -1);
(typeof options.issuer === 'string' && payload.iss !== options.issuer) ||
(Array.isArray(options.issuer) && options.issuer.indexOf(payload.iss) === -1);

if (invalid_issuer) {
return done(new JsonWebTokenError('jwt issuer invalid. expected: ' + options.issuer));
Expand Down