Skip to content

fix(data_classes): support {proxy+} and path parameters in authorizer response #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leandrodamascena wants to merge 1 commit into
base: develop
Choose a base branch
from
+35 −1
Open

fix(data_classes): support {proxy+} and path parameters in authorizer response #8092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws_lambda_powertools/utilities/data_classes/api_gateway_authorizer_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ class APIGatewayAuthorizerResponse:
- https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-lambda-authorizer-output.html
"""

path_regex = r"^[/.a-zA-Z0-9-_\*]+$"
path_regex = r"^[/.a-zA-Z0-9\-_\*\{\}\+]+$"
"""The regular expression used to validate resource paths for the policy"""

def __init__(
Expand Down
34 changes: 34 additions & 0 deletions tests/unit/data_classes/required_dependencies/test_api_gateway_authorizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,40 @@ def test_authorizer_response_allow_route_with_underscore(builder: APIGatewayAuth
}


def test_authorizer_response_allow_route_with_proxy_plus(builder: APIGatewayAuthorizerResponse):
builder.allow_route(http_method="GET", resource="/{proxy+}")
assert builder.asdict() == {
"principalId": "foo",
"policyDocument": {
"Version": "2012-10-17",
"Statement": [
{
"Action": "execute-api:Invoke",
"Effect": "Allow",
"Resource": ["arn:aws:execute-api:us-west-1:123456789:fantom/dev/GET/{proxy+}"],
},
],
},
}


def test_authorizer_response_allow_route_with_path_parameter(builder: APIGatewayAuthorizerResponse):
builder.allow_route(http_method="GET", resource="/users/{user_id}")
assert builder.asdict() == {
"principalId": "foo",
"policyDocument": {
"Version": "2012-10-17",
"Statement": [
{
"Action": "execute-api:Invoke",
"Effect": "Allow",
"Resource": ["arn:aws:execute-api:us-west-1:123456789:fantom/dev/GET/users/{user_id}"],
},
],
},
}


def test_parse_api_gateway_arn_with_resource():
mock_event = {
"type": "TOKEN",
Expand Down
Loading