fix: make add command description consistent with remove#773
Open
Hweinstock wants to merge 1 commit intoaws:mainfrom
Open
fix: make add command description consistent with remove#773Hweinstock wants to merge 1 commit intoaws:mainfrom
Hweinstock wants to merge 1 commit intoaws:mainfrom
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-773-tarball/aws-agentcore-0.6.0.tgz |
vivdalal
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
addcommand description enumerates resource types in a parenthetical:This list is stale — it is missing
gateway,gateway-target,policy-engine, andpolicy, and usestargetinstead ofgateway-target. Rather than updating the list (which will go stale again), this changes the description to be consistent with theremovecommand:removeRemove resources from project config.addAdd resources (agent, evaluator, online-eval, memory, credential, target)Add resources to project config.The subcommand list directly below the description already serves as the authoritative enumeration.
Related Issue
N/A — found during bug bash.
Type of Change
Testing
npm run typechecknpm run lintString-only change — no behavioral impact.
Checklist