Adds create and version branch key functionality#1652
Open
sharmabikram wants to merge 5 commits intomasterfrom
Open
Adds create and version branch key functionality#1652sharmabikram wants to merge 5 commits intomasterfrom
sharmabikram wants to merge 5 commits intomasterfrom
Conversation
* feat: Adds VersionKey API to version the branch key * fix: removes console log which caused the lint failures --------- Co-authored-by: Bikram Sharma <shbikram@amazon.com>
…ersioning a branch key
…and JavaScript implementation
…ain internal prefix
texastony
approved these changes
Mar 20, 2026
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
LGTM, but we need a one off interopt test.
Comment on lines
+84
to
+85
| //= aws-encryption-sdk-specification/framework/branch-key-store.md#writing-branch-key-and-beacon-key-to-keystore | ||
| //# - "hierarchy-version" (N): 1 |
Contributor
There was a problem hiding this comment.
Praise: Well done on grabbing non-RFC duvet annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The change adds createKey and versionKey API to functionality to this library.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: