fix(ci): fix VERSION_BUMP scoping and remove unused NPM token from publish job#1653
Merged
lucasmcdonald3 merged 1 commit intomasterfrom Mar 20, 2026
Merged
fix(ci): fix VERSION_BUMP scoping and remove unused NPM token from publish job#1653lucasmcdonald3 merged 1 commit intomasterfrom
lucasmcdonald3 merged 1 commit intomasterfrom
Conversation
lucasmcdonald3
force-pushed
the
fix-release-workflow
branch
from
913f1e8 to
2515515
Compare
…blish job Move VERSION_BUMP env var to the Version packages step where it is actually used, and remove it from Configure git where it was unused. Remove AWS credentials and NPM token fetch from the publish job since OIDC trusted publishing handles auth via id-token.
lucasmcdonald3
force-pushed
the
fix-release-workflow
branch
from
2515515 to
d03780a
Compare
josecorella
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Two fixes to the release workflow:
VERSION_BUMPenv var was only scoped to the "Configure git" step but referenced in the "Version packages" step. Moved it to the correct step (and removed it from "Configure git" where it was unused) solerna versionactually receives the override when provided.Removed AWS credentials and NPM token fetch from the publish job. With Lerna 9 and OIDC trusted publishing (
id-token: write), the publish auth is handled automatically. The packages are all public so no token is needed for registry reads either.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: